fix(events): remove malformed duplicate invoice_expired definition - #720
Merged
Kingsman-99 merged 1 commit intoAug 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix malformed duplicate
invoice_expireddefinition inevents.rsSummary
This PR fixes a pre-existing compile error on
mainincontracts/split/src/events.rs. There were two definitions ofinvoice_expired:env.events().publish(...)call was missing the closing
)and the closing}of the function, and thesecond
pub fn invoice_expiredbegan inside that unterminated call.The only caller (
lib.rs:11004) invokesinvoice_expired(&env, invoice_id, deadline, funded, &invoice.creator)— the 5-arg form — so the intendedfunction is the first one. This PR keeps that form and removes the malformed
tail + the duplicate, yielding a single, correctly-terminated function.
Before
After
Verification
Resolves the
unclosed delimiterparse error atevents.rs:1821, which wasblocking
cargo checkfor the wholesplitcrate. (Note: additional, unrelatedcompile errors remain on
mainfrom other unimplemented helpers/variants thatare tracked by their own issues; this PR addresses only the duplicate-function
parse error.)
This is a housekeeping fix for a pre-existing parse error and is not tied to a
specific campaign issue; it is opened to unblock
cargo checkonmain.