docs: add issue specs for Tiered threshold, auto_resolve Refund, compact round-trip and ReturnSurplus tests (#665 #666 #668 #669) - #726
Merged
Conversation
…ct round-trip, and ReturnSurplus tests (Stellar-split#665 Stellar-split#666 Stellar-split#668 Stellar-split#669) - ISSUE_TIERED_SPLIT_RULE_THRESHOLD_TESTS.md: documents three tests for SplitRule::Tiered threshold boundary (below/above/independent rules), covering the zero-payout else-branch in _release_full. Closes Stellar-split#665. - ISSUE_AUTO_RESOLVE_REFUND_TESTS.md: documents four tests for the ResolveAction::Refund path of auto_resolve, including threshold guard, state-changed event, and multi-payer balance restoration. Closes Stellar-split#666. - ISSUE_COMPACT_SERIALIZATION_ROUNDTRIP.md: documents four unit tests for Invoice::to_compact / from_compact round-trip across status, funded, and deadline fields with edge-case values (zero, max, negative). Closes Stellar-split#668. - ISSUE_RETURN_SURPLUS_OVERPAYMENT_TESTS.md: documents integration tests for OverfundingPolicy::ReturnSurplus verifying surplus refund, funded cap, and event behaviour on overpayment. Closes Stellar-split#669.
|
@brightfootlimited-collab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary Adds four issue-specification documents that define the missing test coverage identified in issues closes #665, closes #666, closes #668 and closes #669. No production code is changed. --- ## Documents added | File | Closes | |------|--------| | \docs/ISSUE_TIERED_SPLIT_RULE_THRESHOLD_TESTS.md\ | #665 | | \docs/ISSUE_AUTO_RESOLVE_REFUND_TESTS.md\ | #666 | | \docs/ISSUE_COMPACT_SERIALIZATION_ROUNDTRIP.md\ | #668 | | \docs/ISSUE_RETURN_SURPLUS_OVERPAYMENT_TESTS.md\ | #669 | --- ## What each document covers ### #665 — \SplitRule::Tiered\ threshold boundary Three tests for the zero-payout \else\ branch in _release_full: - \ unded = 999\ (below threshold 1000) → recipient receives \