Skip to content

feat: implement issues #735, #736, #737, #738 - #739

Merged
Kingsman-99 merged 1 commit into
Stellar-split:mainfrom
judikay95:feat/issues-735-736-737-738
Aug 31, 2026
Merged

feat: implement issues #735, #736, #737, #738#739
Kingsman-99 merged 1 commit into
Stellar-split:mainfrom
judikay95:feat/issues-735-736-737-738

Conversation

@judikay95

Copy link
Copy Markdown
Contributor

#735 – Add get_escrow_balance(invoice_id) view to invoice-escrow contract

  • Read-only fn returns funded_amount for the invoice, or 0 if unknown
  • Two unit tests: existing invoice returns correct balance, unknown returns 0

#736 – Add EscrowReleased event to invoice-escrow release function

  • EscrowReleased { invoice_id, recipient, amount } struct added to types.rs
  • Emitted via env.events().publish() after transfer succeeds in release()
  • Unit test asserts event appears in emitted events list after release

#737 – Add /// doc comments to all public functions in factory contract

  • initialize, deploy_invoice_contract, get_deployments, is_salt_used, and contract_deployed helper all have full Rust doc comments
  • Documents params, return values, panics — no logic changes

#738 – Add storage snapshot tests for invoice state persistence

  • storage_roundtrip_write_then_read_equals_original
  • storage_partial_update_does_not_overwrite_unrelated_keys
  • storage_missing_key_returns_none_without_panic
  • All use Soroban persistent storage directly

chore: clean up .gitignore — sectioned, deduplicated, tests/snapshots/ excluded

closes #735
closes #736
closes #737
closes #738

…split#737, Stellar-split#738

Stellar-split#735 – Add get_escrow_balance(invoice_id) view to invoice-escrow contract
  - Read-only fn returns funded_amount for the invoice, or 0 if unknown
  - Two unit tests: existing invoice returns correct balance, unknown returns 0

Stellar-split#736 – Add EscrowReleased event to invoice-escrow release function
  - EscrowReleased { invoice_id, recipient, amount } struct added to types.rs
  - Emitted via env.events().publish() after transfer succeeds in release()
  - Unit test asserts event appears in emitted events list after release

Stellar-split#737 – Add /// doc comments to all public functions in factory contract
  - initialize, deploy_invoice_contract, get_deployments, is_salt_used,
    and contract_deployed helper all have full Rust doc comments
  - Documents params, return values, panics — no logic changes

Stellar-split#738 – Add storage snapshot tests for invoice state persistence
  - storage_roundtrip_write_then_read_equals_original
  - storage_partial_update_does_not_overwrite_unrelated_keys
  - storage_missing_key_returns_none_without_panic
  - All use Soroban persistent storage directly

chore: clean up .gitignore — sectioned, deduplicated, tests/snapshots/ excluded
@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@judikay95 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Kingsman-99
Kingsman-99 merged commit ec10efd into Stellar-split:main Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants