feat: implement issues #735, #736, #737, #738 - #739
Merged
Kingsman-99 merged 1 commit intoAug 31, 2026
Conversation
…split#737, Stellar-split#738 Stellar-split#735 – Add get_escrow_balance(invoice_id) view to invoice-escrow contract - Read-only fn returns funded_amount for the invoice, or 0 if unknown - Two unit tests: existing invoice returns correct balance, unknown returns 0 Stellar-split#736 – Add EscrowReleased event to invoice-escrow release function - EscrowReleased { invoice_id, recipient, amount } struct added to types.rs - Emitted via env.events().publish() after transfer succeeds in release() - Unit test asserts event appears in emitted events list after release Stellar-split#737 – Add /// doc comments to all public functions in factory contract - initialize, deploy_invoice_contract, get_deployments, is_salt_used, and contract_deployed helper all have full Rust doc comments - Documents params, return values, panics — no logic changes Stellar-split#738 – Add storage snapshot tests for invoice state persistence - storage_roundtrip_write_then_read_equals_original - storage_partial_update_does_not_overwrite_unrelated_keys - storage_missing_key_returns_none_without_panic - All use Soroban persistent storage directly chore: clean up .gitignore — sectioned, deduplicated, tests/snapshots/ excluded
|
@judikay95 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#735 – Add get_escrow_balance(invoice_id) view to invoice-escrow contract
#736 – Add EscrowReleased event to invoice-escrow release function
#737 – Add /// doc comments to all public functions in factory contract
#738 – Add storage snapshot tests for invoice state persistence
chore: clean up .gitignore — sectioned, deduplicated, tests/snapshots/ excluded
closes #735
closes #736
closes #737
closes #738