Skip to content

fix: validate early_bird_fee_bps does not exceed platform fee at creation (#696) #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kingsman-99 merged 2 commits into from
Aug 31, 2026
+9 −17
Merged

fix: validate early_bird_fee_bps does not exceed platform fee at creation (#696) #741

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35846de
fix: validate early_bird_fee_bps does not exceed platform fee at crea…
deborahairtel887-dotcom Aug 30, 2026
bc12b97
Merge branch 'main' into fix/issue-696-validate-early-bird-fee-bps
Kingsman-99 Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions contracts/split/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5427,29 +5427,21 @@ impl SplitContract {
assert!(min_funding_bps <= 10_000, "min_funding_bps must be ≤ 10000");
assert_valid_bps(tax_bps).expect("tax_bps must be ≤ 10000");
assert_valid_bps(insurance_premium_bps).expect("insurance_premium_bps must be ≤ 10000");
// Issue #489: early-bird discounted platform fee must not exceed the
// standard fee in effect for this creator at creation time.
assert!(
early_bird_fee_bps <= 10_000,
"early_bird_fee_bps must be ≤ 10000"
);
if early_bird_window_ledgers > 0 {
let standard_fee_bps = Self::get_applicable_fee(env.clone(), creator.clone());
assert!(
early_bird_fee_bps <= standard_fee_bps,
"early_bird_fee_bps must not exceed the standard platform fee"
);
// Issue #489 / #696: early-bird discounted platform fee must not exceed the
// platform fee read from contract storage at creation time.
let platform_fee_bps: u32 = env
.storage()
.instance()
.get(&platform_fee_bps_key())
.unwrap_or(0u32);
if early_bird_fee_bps > platform_fee_bps {
env.panic_with_error(ContractError::InvalidAmount);
}
// Issue #559: creator fee must be within bounds and not exceed cap with platform fee.
assert!(
creator_fee_bps <= 10_000,
"creator_fee_bps must be ≤ 10000"
);
let platform_fee_bps: u32 = env
.storage()
.instance()
.get(&platform_fee_bps_key())
.unwrap_or(0u32);
assert!(
(creator_fee_bps as u64 + platform_fee_bps as u64) <= 10_000,
"FeeSumExceedsCap"
Expand Down
Loading