fix(#694): reject min_funding_bps > 10 000 at invoice creation

[CodedBay]

Summary

min_funding_bps sets the minimum percentage of the invoice total that must be funded before release. Previously there was no bounds check; a value above 10 000 would require more than 100% funding, making the invoice permanently unreleasable.

This PR replaces the bare assert! macro with panic_with_error!(env, ContractError::InvalidAmount), firing before any storage is written when min_funding_bps > 10_000.

What was changed

contracts/split/src/lib.rs

Replaced the old assert! with a typed error guard in _create_invoice_inner:

// Before
assert!(min_funding_bps <= 10_000, "min_funding_bps must be ≤ 10000");

// After — Issue #694
if min_funding_bps > 10_000 {
    panic_with_error!(env, ContractError::InvalidAmount);
}

contracts/split/src/test.rs

Two new unit tests:

• test_min_funding_bps_above_10000_rejected — min_funding_bps=10_001 → panics (#[should_panic])
• test_min_funding_bps_exactly_10000_accepted — min_funding_bps=10_000 → invoice created successfully (boundary value)

Acceptance criteria (from issue)

• create_invoice returns ContractError::InvalidAmount when min_funding_bps > 10_000
• Validation is present before any storage writes
• Unit test: min_funding_bps = 10_001 is rejected
• Unit test: min_funding_bps = 10_000 is accepted

Closes #694

[drips-wave]

@CodedBay Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits