feat: three-way merge for diff.ts and warmUpMs for StandbyController … - #796
Merged
Kingsman-99 merged 1 commit intoAug 31, 2026
Conversation
…tellar-split#702, Stellar-split#703) Issue Stellar-split#703 — diff.ts three-way merge conflict detection: - Add MergeConflictError to src/errors.ts with field, baseValue, localValue, remoteValue properties - Add mergeInvoices(base, local, remote) to src/diff.ts implementing the three-way merge algorithm: - Both branches unchanged → keep base value - Only one branch changed → fast-forward to that value - Both changed to same value → no conflict, use that value - Both changed to different values → throw MergeConflictError - 17 unit tests in test/diff.test.ts covering all three merge outcomes Issue Stellar-split#702 — standby.ts configurable warm-up period: - Add StandbyController class to src/standby.ts with: - warmUpMs?: number option (default: 0) - inactivityMs?: number option (default: 30_000) - During warmUpMs window, inactivity does not trigger standby - After warm-up, normal inactivity detection resumes - recordActivity() resets the inactivity timer (post warm-up only) - standby getter, onStandby(listener), start(), stop() - 12 unit tests in test/standby.test.ts covering all acceptance criteria
|
@mctituschristian Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#702, #703)
Issue #703 — diff.ts three-way merge conflict detection:
Issue #702 — standby.ts configurable warm-up period:
Closes standby.ts: Add configurable warm-up period before standby mode activates #702
Closes diff.ts: Write tests for three-way merge conflict detection #703