feat(splitExecutor): validate recipient ratios sum to 1.0 before execution (#778) - #816
Open
ZacLou wants to merge 1 commit into
Open
feat(splitExecutor): validate recipient ratios sum to 1.0 before execution (#778)#816ZacLou wants to merge 1 commit into
ZacLou wants to merge 1 commit into
Conversation
…ution (Stellar-split#778) - Add optional field to interface - Introduce (1e-9) exported constant - Throw with actual sum when ratios don't total 1.0 - Skip validation when no ratios are provided (backwards compatible) - Add unit tests for exact sum, under-sum, over-sum, and tolerance edge cases Closes Stellar-split#778
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ratio-sum validation to
splitExecutorso malformed splits fail fast with a clear error instead of producing silent over- or under-payments.Changes
SplitRecipient.ratio?: number— optional share ratio (0.0–1.0).SPLIT_RATIO_TOLERANCE = 1e-9(exported).SplitRatioSumErrorthrown when provided ratios do not sum to 1.0 within tolerance.test/splitExecutor.test.tscovers exact sum, under-sum, over-sum, floating-point tolerance, and error property assertions.Closes #778