feat(cache): implement stale-while-revalidate in OptimisticCache (#776) - #819
Open
ZacLou wants to merge 1 commit into
Open
feat(cache): implement stale-while-revalidate in OptimisticCache (#776)#819ZacLou wants to merge 1 commit into
ZacLou wants to merge 1 commit into
Conversation
…llar-split#776) - Add OptimisticCacheOptions with staleWhileRevalidateMs (default 0) - Add optional revalidate callback for background refresh - Return stale values immediately while triggering background revalidation - Prevent concurrent revalidations per key via in-flight tracking - Emit revalidateError events when background refresh fails - Add peek(), resolveTtl(), and enabledState to SimpleCache for SWR support - Add unit tests for stale detection, concurrency guard, and error emission Closes Stellar-split#776
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds stale-while-revalidate (SWR) support to
OptimisticCacheso UIs never block on a TTL boundary.Changes
OptimisticCacheOptions:staleWhileRevalidateMs— time window before expiry where a value is considered stale but still served (default0, i.e. disabled).revalidate— async callback invoked in the background to fetch a fresh value.get()hits a stale entry, the stale value is returned immediately.revalidateErrorevent is emitted; the caller is unaffected.src/cache.ts):peek(key)— read raw entry metadata without evicting or counting hits.resolveTtl(method)— return the configured TTL for a method prefix.enabledStategetter.test/optimisticCacheSwr.test.tscovers stale detection, non-stale skipping, disabled SWR, concurrency guard, error emission, and post-error staleness.Closes #776