feat(anchors): validate TOML schema VERSION in StellarTomlParser (#779) - #821
Open
ZacLou wants to merge 1 commit into
Open
feat(anchors): validate TOML schema VERSION in StellarTomlParser (#779)#821ZacLou wants to merge 1 commit into
ZacLou wants to merge 1 commit into
Conversation
…llar-split#779) - Add SUPPORTED_TOML_VERSIONS exported constant (["2.0", "2.1"]) - Check VERSION field immediately after successful TOML parse - Throw UnsupportedTomlVersionError with version and supported list on mismatch - Accept documents with no VERSION field (backwards compatible) - Add unit tests for supported, unsupported, missing, and error shape Closes Stellar-split#779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds VERSION field validation to StellarTomlParser so future schema-breaking changes are rejected instead of silently producing incorrect data.
Changes
SUPPORTED_TOML_VERSIONS = ["2.0", "2.1"]_parsenow checksparsed.VERSIONimmediately after successful TOML parsingUnsupportedTomlVersionErrorwith the encountered version and supported listUnsupportedTomlVersionErrorwithversionpropertytest/stellarTomlParserVersion.test.tscovers supported version, unsupported version, missing VERSION, and error shapeCloses #779