feat(wallets): handle Freighter not-installed with friendly error (#772) - #824
Open
ZacLou wants to merge 1 commit into
Open
feat(wallets): handle Freighter not-installed with friendly error (#772)#824ZacLou wants to merge 1 commit into
ZacLou wants to merge 1 commit into
Conversation
…ellar-split#772) - Add FreighterNotInstalledError with install URL in message - Check window.freighter presence before connect, sign, and getAddress - Throw FreighterNotInstalledError instead of raw TypeError - Existing logic unchanged when extension is present - Add unit tests for missing extension, error message, and normal flow Closes Stellar-split#772
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces cryptic TypeError with a clear, actionable error when the Freighter extension is missing.
Changes
Closes #772