fix(auth): handle unique-constraint violation in register as 409 Conflict (#55) - #68
Open
ghzhost wants to merge 1 commit into
Open
fix(auth): handle unique-constraint violation in register as 409 Conflict (#55)#68ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #55.
When two concurrent
POST /api/auth/registerrequests race on the same email, both could pass the initialSELECT EXISTS(...)query, hash the password via bcrypt (~100-300ms race window), and attemptINSERT INTO users. The database UNIQUE constraint correctly prevents duplication, but the second insert previously triggered a 500AppError::Database/ internal server error rather than409 Conflict.Changes
is_unique_violation(error: &sqlx::Error) -> booltocrate::db::is_unique_violationas a shared helper across the codebase.services::batch,services::escrow, andservices::subscriptionto usecrate::db::is_unique_violationrather than duplicating the helper function.register'sINSERT INTO usersquery with.map_err(...)checkingis_unique_violation(&e)and mapping unique constraint violations directly toAppError::Conflict("Email".into()).