fix(rates): instantiate RateService singleton in AppState to enable cache (#36) - #69
Open
ghzhost wants to merge 1 commit into
Open
fix(rates): instantiate RateService singleton in AppState to enable cache (#36)#69ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #36 by instantiating
RateServiceonce at startup and storing it inAppState, allowingGET /api/ratesto properly share and leverage the in-memory TTL cache across requests.Changes
pub rate_service: services::rate::RateServicetoAppStateand initialized it once during startup insrc/main.rsusing the configuredhorizon_urlandrate_cache_ttl_secs.src/routes/rates.rsto callstate.rate_service.fetch_rate(...)directly instead of allocating a freshRateService(with a discarded empty cache) on every request.src/services/rate.rsverifying that cache hits occur within the configured TTL window without repeating outbound calls to Horizon.