fix(auth): mitigate login timing side-channel via dummy bcrypt hash (#38) - #71
Open
ghzhost wants to merge 1 commit into
Open
fix(auth): mitigate login timing side-channel via dummy bcrypt hash (#38)#71ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
…tellarSend#38) - Always execute bcrypt::verify even if user email is not found or account is inactive - Uses a valid cost-12 dummy hash to equalize latency across existing and non-existing accounts - Returns identical 401 INVALID_CREDENTIALS error response - Closes StellarSend#38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #38 by closing the observable timing discrepancy (CWE-208) in
src/routes/auth.rs::login.Changes
DUMMY_BCRYPT_HASHwith standard cost factor 12) for nonexistent / inactive accounts.loginnow always runsbcrypt::verifybefore checking user presence, equalizing execution time between existing and nonexistent email lookups.AppError::InvalidCredentials->401 INVALID_CREDENTIALS).DUMMY_BCRYPT_HASHparses and verifies safely.Closes #38.