fix(cors): enforce explicit allowed_origins in production and restrict methods/headers (#24) - #80
Open
ghzhost wants to merge 1 commit into
Open
Conversation
…t methods/headers (StellarSend#24) - Require explicit non-wildcard ALLOWED_ORIGINS when APP_ENV=production in Config::from_env - Restrict AllowMethods to GET, POST, OPTIONS - Restrict AllowHeaders to Authorization, Content-Type, Accept, X-Request-Id - Set max_age for preflight caching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #24 by:
Config::from_env(): whenAPP_ENVisproduction/prod, startup fails withbail!ifALLOWED_ORIGINSis unset, empty, or contains'*'.AllowMethodsinbuild_cors_layerfromAllowMethods::any()to explicit API methods:GET,POST,OPTIONS.AllowHeadersfromAllowHeaders::any()to explicit necessary headers:Authorization,Content-Type,Accept, andX-Request-Id.max_age(Duration::from_secs(3600))for preflight caching.src/middleware/cors.rs.Fixes #24.