fix(subscriptions): do not silently fall back to one-time payment on create failure (#15) - #102
Open
ghzhost wants to merge 1 commit into
Open
Conversation
…create failure (StellarSend#15) Closes StellarSend#15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Problem
In
useCreateSubscription, whensubscriptionApi.buildCreateTransactionthrew an error (for example 501 / backend unavailable / invalid params), the catch block silently fell back to building a plain, one-timebuildPaymentTransactionlocally and proceeded through signing and submission tosubscriptionApi.create.This meant the user unknowingly signed and submitted an immediate, full one-time payment instead of a recurring subscription schedule.
Solution
buildPaymentTransactioninuseCreateSubscription.subscriptionApi.buildCreateTransactiondirectly so the mutation transitions to error state and warns the user.src/hooks/useCreateSubscription.test.tsxverifying errors properly reject the mutation without callingbuildPaymentTransactionorsubscriptionApi.create.Verification
NODE_ENV=test npm test: 28 test files passed (117 tests total).