fix(common): add componentDidCatch logging and onError callback to ErrorBoundary (#11) - #85
Open
ghzhost wants to merge 1 commit into
Open
fix(common): add componentDidCatch logging and onError callback to ErrorBoundary (#11)#85ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
src/components/common/ErrorBoundary.tsximplementedgetDerivedStateFromErrorto transition state and show fallback UI, but lackedcomponentDidCatch(error, info)to log the caught error toconsole.erroror forward to diagnostic/monitoring callbacks. In production, component render crashes were completely silent and untraceable.Fix
componentDidCatch: AddedcomponentDidCatch(error: Error, info: ErrorInfo)to log errors viaconsole.error("[ErrorBoundary] Caught render error:", error, info.componentStack).onErrorcallback hook: Added optionalonError?: (error: Error, info: ErrorInfo) => voidprop toErrorBoundaryPropsto allow forwarding caught errors to error-tracking services (e.g. Sentry/LogRocket).hasError: falseanderror: undefined.src/components/common/ErrorBoundary.test.tsxverifying:componentDidCatchlogging toconsole.errorand default fallback UI rendering on render error.onErrorcallback with error and component stack info.fallbackprop is provided.Verification
npx vitest run src/components/common/ErrorBoundary.test.tsx(4/4 passed)npx vitest run(117/117 passed across all 28 test suites)npx tsc --noEmit(clean)npm run build(succeeded)Closes #11