fix(theme): configure darkMode class strategy and style common components (#41) - #86
Open
ghzhost wants to merge 1 commit into
Open
fix(theme): configure darkMode class strategy and style common components (#41)#86ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
…ents (StellarSend#41) - Add `darkMode: 'class'` to tailwind.config.js so useTheme's class toggle correctly drives dark: variants - Update common/Skeleton and common/NetworkError to use app navy and slate palette matching fixed design system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #41
darkMode: 'class'intailwind.config.jsso Tailwind'sdark:variants react directly to thedarkclass managed byuseThemeon the<html>element, instead of falling back to the OS-onlymediaquery default.src/components/common/Skeleton.tsxandsrc/components/common/NetworkError.tsxto use the app's established navy/slate color palette tokens (bg-navy-700/60,text-slate-300,text-slate-500) matching the rest of the dark design system.Validation
NODE_ENV=test npm test(all 27 test files / 113 tests passing).