fix(settings): wire appearance theme picker and DarkModeToggle into app (#38) - #91
Open
ghzhost wants to merge 1 commit into
Open
fix(settings): wire appearance theme picker and DarkModeToggle into app (#38)#91ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
…pp (StellarSend#38) - Merge theme selection (light, dark, system) into routed Settings page under Appearance & Display section. - Render DarkModeToggle in Navbar (both desktop and mobile drawer) for quick theme toggling. - Add Settings.test.tsx integration test verifying theme toggle interactions and document class / localStorage updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #38 by integrating the existing theme subsystem directly into the reachable application UI:
Appearance & Display Section in
pages/Settings.tsx:Sun,Moon,Laptop), and active state highlighting usinguseTheme().Quick Theme Switching in
Navbar.tsx:<DarkModeToggle />in the top right navbar for desktop view.Testing:
src/pages/Settings.test.tsxverifying the Appearance section renders theme buttons and clicking them updates the document class andlocalStoragecorrectly.Fixes #38