fix(pay-request): lock amount/destination in SendForm and re-validate on submit (#26) - #92
Open
ghzhost wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26
Problem
PayRequest.tsxpreviously passed requested amount and destination toSendFormviadefaultValues, leaving the inputs editable by the payer before quote/payment submission. Additionally, if the payment request status changed (e.g., cancelled or expired) or if fields were modified, the submission could proceed without re-validating the fresh state against Horizon/backend.Solution
lockedFieldssupport toSendForm, markingdestinationAddress,amount,destinationAssetCode, andamountTypeas read-only / disabled inPayRequest.PayRequestsonSubmithandler to re-fetch latest request state (refetch()) and ensure the request is stillopenand matchingrequesterPublicKey,amount, andassetCodebefore requesting a quote.src/pages/PayRequest.test.tsxverifying field locking and stale/cancelled request blocking.