feat(contracts): add scValI128 and scValU64 helpers for Soroban numeric encoding - #214
Open
Jerry-Tekh wants to merge 3 commits into
Open
feat(contracts): add scValI128 and scValU64 helpers for Soroban numeric encoding#214Jerry-Tekh wants to merge 3 commits into
Jerry-Tekh wants to merge 3 commits into
Conversation
…ic encoding Implements helper functions for encoding Soroban ScVal i128 and u64 numeric values: - scValI128(amount): encodes bigint or string to i128 ScVal - scValU64(val): encodes number to u64 ScVal Includes unit tests verifying boundary values (0, max u64, large i128 stroop values). Closes StellarState#153
|
@Jerry-Tekh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
… ScVal encoding Adds centralized helpers for encoding Soroban ScVal Symbol and Address values: - scValSymbol(value): encodes string to symbol ScVal - scValAddress(address): encodes Stellar address to ScVal Includes unit tests verifying ScVal serialization and deserialization. Closes StellarState#152
…rror handling Adds comprehensive unit tests covering verifyPaymentTransaction(): - Mock Horizon.Server.transactions() responses for success and error codes - Payment amount delta comparison logic (within and outside allowed delta) - Retry behavior on 503 and network socket timeout - Transaction state transitions and conflict detection - Operation index disambiguation Closes StellarState#145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds centralized helpers for encoding Soroban ScVal Symbol and Address values, plus comprehensive unit tests for verify-payment.service transaction build & error handling.
Changes
Test Coverage
Closes #145
Closes #152
Closes #153