skip: skipped KYC upload logging as requested - #244
Open
probablyABug wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @probablyABug, thanks for your contribution! 🙏 A quick heads-up on your PR: the commit prefix Please update your commit message to use a valid type. Common valid types include:
Please amend/rebase your commit(s) and force-push to fix the commit message so CI can pass cleanly. Let us know if you need any help! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #203
Adds structured info-level logging for successful KYC document uploads to provide an audit trail for document submissions. Each successful upload records the seller wallet, document type, file size, IPFS CID, and upload timestamp after the CID has been successfully persisted. File names and document contents are explicitly excluded from logs to prevent sensitive KYC data from being exposed.
Type of Change
Checklist
feat:,fix:,chore:, etc.) — enforced by CI.env, or credentials committed (seeCONTRIBUTING.md)Testing
Added coverage for successful KYC document upload logging, including verification of the structured fields, upload ordering, document type, and sensitive data exclusion.
How to Test
passportornational_id.wallet,document_type,file_size_bytes,ipfs_cid, anduploaded_at.document_typematches the type selected by the seller.Test Coverage
Screenshots (if applicable)
Not applicable — this is a backend logging and auditability change.
Additional Notes
The log is emitted only after the IPFS upload succeeds and the resulting CID has been persisted, ensuring the audit record represents a completed upload rather than an attempted one.
Because KYC documents contain sensitive information, the implementation intentionally logs metadata only. File names and document contents are never included in the structured log.
For Reviewers