perf: harden User and Transaction models with targeted indexes - #426
Merged
chizzy192 merged 1 commit intoAug 30, 2026
Merged
Conversation
|
@privexlabs Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the User and Transaction TypeORM entities for heavy-load resilience and query performance, addressing sub-optimal data fetching patterns and a type-safety gap identified in the Database & Migrations domain.
Changes
src/models/User.model.ts: added a composite index on (userType,kycStatus) to speed up combined user-segment and verification-status lookups; correctedisKycVerifiedto be a requiredboolean(it is a NOT NULL column with a database default, but was typed as optional, allowing an incorrectundefinedstate at compile time).src/models/Transaction.model.ts: added a composite index on (status,type,timestamp) matching the exact filter/sort used by the pending Stellar-state reconciliation worker; added an index onstellar_tx_hashto speed up existing lookups performed during payment verification and reconciliation.src/migrations/1732300000000-AddUserAndTransactionPerformanceIndexes.ts: new migration creating the three indexes above (idempotentCREATE INDEX IF NOT EXISTS, with a matching down migration), following the repository's existing migration conventions.Issues
Resolves #333
Resolves #334
Resolves #335
Resolves #336
Verification
git status,git diff --stat, and the fullgit diffwere inspected; only the two targeted model files and one new migration file are changed.cargo buildwas not run.cargo testwas not run.