test(keys): add unit tests for vote modal option index and submission… - #270
Open
FrankHood1 wants to merge 1 commit into
Open
test(keys): add unit tests for vote modal option index and submission…#270FrankHood1 wants to merge 1 commit into
FrankHood1 wants to merge 1 commit into
Conversation
… states Add unit tests covering the VoteModal acceptance criteria: - Correct option index passed to the contract for each selectable option - Confirm button disabled until an option is selected - Confirm button disabled and 'Vote recorded' shown after a successful vote - Error message shown on contract failure and Confirm re-enabled Also fix VoteModal handleSubmit to catch mutation rejections and render an in-modal error message on contract failure.
|
@FrankHood1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for the vote modal asserting the correct option index is submitted and the controls disable appropriately after voting.
Acceptance Criteria Covered
Changes
components/keys/__tests__/VoteModal.test.tsx— new unit test suite forVoteModalcomponents/keys/VoteModal.tsx— wraphandleSubmitin try/catch so a failed contract call no longer produces an unhandled rejection, and render an in-modal error message on failure via the mutation error stateVerification
npx vitest run components/keys/__tests__/VoteModal.test.tsx— 6/6 tests passeslintclean on changed filesCloses #96
Closes #98
Closes #114
Closes #117