fix(parameters): secure multisig against stale approvals, self-degrad… - #109
Closed
KingFRANKHOOD wants to merge 1 commit into
Closed
fix(parameters): secure multisig against stale approvals, self-degrad…#109KingFRANKHOOD wants to merge 1 commit into
KingFRANKHOOD wants to merge 1 commit into
Conversation
…ing quorum, and admin bypass (StepFi-app#107) - Snapshot the eligible signer set into every Proposal; approve() and execute() re-validate each approver against the snapshot AND current membership so removed signers' approvals are never counted and newly added signers cannot influence older proposals (ApproverNotEligible=19). - Require threshold + 1 approvals (capped at full signer count) for UpdateSigners actions so a committee cannot cheapen its own gate. - Split configure_multisig into a two-step propose->confirm flow with a prominent MSCONFPR event before any signer set is activated. - Invalidate in-flight UpdateSigners proposals when the signer set changes (ProposalInvalidated=18, PROPIVLD event). - Tests: 399 workspace tests green, including the stale-approval exploit reproduced end-to-end (fails pre-fix, passes post-fix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locate PR #108
That's the correct PR