Feature/intercom token detection#6
Merged
Merged
Conversation
Add comprehensive tests for the Finding struct in pkg/types/finding_test.go - Test finding creation with all fields - Test zero value initialization - Test all severity levels
Add SetOutput method to allow changing the output writer for the logger - Enables testing with buffer output - Allows redirecting logs to files or other destinations
Add Validate method to Config struct to ensure configuration values are valid - Validates severity_threshold is one of: low, medium, high, critical - Validates max_file_size is positive - Add config_validation_test.go with comprehensive test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Describe the changes in this PR.
Which detectors does it affect?
Testing done
Checklist
Screenshots (if applicable)
Add screenshots to help explain your changes.