fix(cli): fail install when skill links fail#37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rgit installreturn a non-zero exit code when skill symlinks, guidance writes, or installer subprocesses failCloses #34.
Reproduction and verification
Simulated the Windows environment where directory symlink creation fails with
[WinError 1314] A required privilege is not held by the client.main(76f45b5)01✓✗Issue-specific regression tests:
Full suite on native Windows with an isolated pytest temp root:
The additional skips are tests that require real directory-symlink capability; dedicated failure-path tests continue to verify the no-privilege behavior.
Review
Independent read-only review found no Critical, Important, or blocking Minor issues and assessed the change as ready to merge.