fix(agent): surface pending capsule review details#38
Conversation
There was a problem hiding this comment.
Should not have these hard code plain text only test~
There was a problem hiding this comment.
The substring assertions only verify the guidance text, so I ran an isolated host-agent behavior check for the original #35 failure.
Environment:
- temporary Git repository with a real
.rgit/store - one open proposal,
prop_0005bd86bc57 - two stored English candidates:
clamp-negative-totalandexplicit-total-accumulator - one choice-relevant knob:
clamp_negative=false - current PR guidance and the branch version of
rgit-capture/SKILL.mdloaded through an isolated skill home - Codex
gpt-5.6-sol, low reasoning - Chinese user prompt, with approval/dismissal/resegmentation explicitly prohibited
Observed final response:
- listed the proposal id
- listed both stored candidate names
- rendered both one-line intents in Chinese
- included the
clamp_negativeknob - preserved proposal id, candidate names, and config key verbatim
- did not replace the details with a candidate count
Post-run verification also confirmed that the proposal remained open and both stored English intents/knobs were byte-for-byte unchanged; no capsule or graph relation was created.
So the specific user-visible failure from #35 did not reproduce with the PR guidance. One narrower observation: the agent surfaced all review details but did not explicitly ask which names to keep, despite that wording in the skill fallback.
Actual final response from the isolated Codex run:
当前状态已核对,未修改任何文件,也未批准、跳过或改写 proposal。
- 分支:`main`
- 代码修改:`calculator.py`
- 未跟踪目录:`.rgit/`
- 已批准 / 应用 / 跳过的 capsule:无
- 图关系:尚未生成;需在 capsule 审批后处理
### 待审核 Capsule Proposal
Proposal:`prop_0005bd86bc57`
- `clamp-negative-total`
调用方启用限制时,防止汇总结果低于零。
关键参数:`clamp_negative`,默认值为 `false`。
- `explicit-total-accumulator`
显式保存中间汇总结果,使后续的总计策略可以集中应用。
该 proposal 及其两个候选均保持原样、继续待用户审核。
|
Updated the pending-review handoff in Verification:
Sub-agent final response: |
|
Removed the brittle text assertions and documented the isolated Codex behavior check instead. Full suite: |
Summary
Scope
Test plan
python -m pytest -q(535 passed, 2 skipped)Fixes #35