fix(store): make object writes atomic and verifiable#40
Merged
Lum1104 merged 2 commits intoJul 23, 2026
Conversation
KumamuKuma
force-pushed
the
codex/object-store-integrity
branch
from
July 20, 2026 08:54
092bf79 to
d33e44b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
ObjectStore.put previously wrote directly to the final digest path and treated any existing path as valid. An interrupted write could therefore leave a partial object that later puts silently accepted. Doctor only checked object existence, so syntactically valid tampered content could still be reported as healthy.
This keeps ordinary reads lightweight while making writes self-healing and giving doctor an explicit referenced-object integrity audit. Orphan objects are intentionally outside this PR's scope.
Verification
The three remaining failures are the two replaced-external-symlink cases and the python -m source-resolution case already covered by #31.