Skip to content

mention autocomplete does not trigger when there is an active selection #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kobee1203 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mention autocomplete does not trigger when there is an active selection #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions mention/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,17 +381,26 @@
// If the delimiter is a string value convert it to an array. (backwards compatibility)
autoCompleteData.delimiter = (autoCompleteData.delimiter !== undefined) ? !$.isArray(autoCompleteData.delimiter) ? [autoCompleteData.delimiter] : autoCompleteData.delimiter : ['@'];

function prevCharIsSpace() {
var start = ed.selection.getRng(true).startOffset,
text = ed.selection.getRng(true).startContainer.data || '',
charachter = text.substr(start > 0 ? start - 1 : 0, 1);

return (!!$.trim(charachter).length) ? false : true;
function canTriggerAutocomplete() {
var rng = ed.selection.getRng(true);

// Allow autocomplete to be performed to replace the selected text (if any)
var hasSelectedText = rng.startOffset !== rng.endOffset;
if (hasSelectedText) {
return true;
}

// Allow autocomplete after whitespaces (if the preceding text can be trimmed to 0 length string)
var start = rng.startOffset,
text = rng.startContainer.data || '',
character = text.substr(start > 0 ? start - 1 : 0, 1);
var prevCharIsNotSpace = !!$.trim(character).length;
return !prevCharIsNotSpace;
}

ed.on('keypress', function (e) {
var delimiterIndex = $.inArray(String.fromCharCode(e.which || e.keyCode), autoCompleteData.delimiter);
if (delimiterIndex > -1 && prevCharIsSpace()) {
if (delimiterIndex > -1 && canTriggerAutocomplete()) {
if (autoComplete === undefined || (autoComplete.hasFocus !== undefined && !autoComplete.hasFocus)) {
e.preventDefault();
// Clone options object and set the used delimiter.
Expand Down