Enhanced music engine - #39
Open
mysterypaintwo wants to merge 8 commits into
Open
Conversation
…"sust", which is a replacement macro for "rest2"
…mml2wla to the disassembly project; loops truly optimize space now; mml format documentation provided in /audio/ directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the help of AI, the following was done:
[<data>]<number of times to loop>now genuinely saves ROM space. Unfortunately, the vanilla audio assets are untouched at risk of breaking anything.../audio/mml_documentation.md@po<value>; documentation talks about this more/tools/audio/. All the .mml files get compiled into .s WLA source files in the relative/bin/directory next to their respective .mml files.I've tested this fork for both games and it works great; at the very least, this solution now exists and can be used (or at least studied) to develop even cooler things for the games' audio!