fix: make stream state transitions concurrency-safe - #82
Open
greatest0fallt1me wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transition contract
The in-memory store now guards each stream transition with a per-stream async lock and a version predicate. Exactly one request can commit a transition for an observed version; queued requests re-read the resulting state and receive an actionable conflict when the requested transition is no longer valid. Provider failures release the lock without advancing state, allowing a safe retry.
This preserves the existing stream status values and outbox event keys. Legacy records without a stored version are treated as version one for their first guarded transition.
Validation
npm test— 166 passing, 0 failingnode --check src/store/index.jsnode --check src/services/streamService.jsnode --check test/streamConcurrency.test.jsgit diff --checkRelated issue
Closes #71