KCE/KBE-5 #87
Open
KCE/KBE-5 #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strexas
reviewed
Nov 19, 2024
Comment on lines
+244
to
+247
| if os.path.exists(input_vcf): | ||
| os.remove(input_vcf) | ||
| if os.path.exists(output_vcf): | ||
| os.remove(output_vcf) |
Owner
There was a problem hiding this comment.
I can understand removing output in case of error, but why do you remove input?
Comment on lines
+235
to
+243
| try: | ||
| output_vcf = run_spliceai(input_vcf, fasta_path) | ||
| spliceai_scores = parse_spliceai_vcf(output_vcf) | ||
|
|
||
| scores_df = pd.DataFrame(spliceai_scores) | ||
| scores_df.columns = [f"{col}_spliceai" for col in scores_df.columns] | ||
| data_copy = pd.concat([data_copy.reset_index(drop=True), | ||
| scores_df.reset_index(drop=True)], axis=1) | ||
| finally: |
Owner
There was a problem hiding this comment.
What error expected? If error happens, how do we know what error happened?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented revel with optional parameters for geneticist. Method was reformatted from Nojus' method
Method was not tested due to time required to test it.