Skip to content

fix: follow symlinks when grepping for desktop entries #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cluther wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: follow symlinks when grepping for desktop entries #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion freedesktop/browser_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func (b *BrowserService) GetAvailableBrowsers() ([]linkquisition.Browser, error)

// grep all the .desktop files in the paths for the category "WebBrowser":
grepArgs := []string{
"-r",
"-R",
"-l",
"-E",
"^Categories=.*WebBrowser",
Expand Down
2 changes: 1 addition & 1 deletion freedesktop/xdg_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func (x *XdgService) GetDesktopEntryPathForBinary(binary string) (string, error)

// grep all the .desktop files in the paths for the binary basename and return the first match:
pattern := fmt.Sprintf("^Exec=(%s|%s)", binary, filepath.Base(binary))
grepArgs := []string{"-r", "-l", "-m", "1", "-E", pattern, "--include", "*.desktop"}
grepArgs := []string{"-R", "-l", "-m", "1", "-E", pattern, "--include", "*.desktop"}
grepArgs = append(grepArgs, paths...)
cmd := exec.Command("grep", grepArgs...)

Expand Down