fix(stripe-style): form-encoded bodies are valid, not bad JSON - #57
Merged
Conversation
Real SDK clients (stripe-node) POST application/x-www-form-urlencoded, which the engine now parses into nested req.body structures — the _bad_body JSON guard was rejecting them with 400 'could not parse as JSON' before handlers ran. Found by dogfooding a real stripe-node client against the checkout-session create flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the bracket-notation form parser (#56): real SDK clients POST
application/x-www-form-urlencoded, which the engine now turns into nestedreq.bodystructures — but_bad_bodystill demanded decodable JSON and 400'd SDK creates before handlers ran. Form content-type is now accepted (the engine already parsed it); JSON bodies keep the strict malformed-JSON 400.Proven end-to-end: a real stripe-node client creates a checkout session, the hosted page completes it, and the receiver's
webhooks.constructEventverifies the Stripe-Signature and parsesevent.data.object— plus tamper-rejection.