Refactor for-loop iterations to use numeric indexing (Micro-Optimization)#271
Open
Vitroze wants to merge 4 commits intoStyledStrike:mainfrom
Open
Refactor for-loop iterations to use numeric indexing (Micro-Optimization)#271Vitroze wants to merge 4 commits intoStyledStrike:mainfrom
Vitroze wants to merge 4 commits intoStyledStrike:mainfrom
Conversation
- Updated multiple files to replace `ipairs` with numeric indexing for better performance and consistency. - This change affects various entities and client/server scripts, ensuring that iteration over arrays is done using a standard numeric approach. - The changes enhance readability and maintainability of the codebase.
Contributor
Author
|
I'll sort out the style issues this evening. |
Contributor
|
I don't think it will speed up anything, LuaJIT handles this just fine |
Contributor
Author
However, according to another developer's benchmark, this changes. In fact, this is interesting when the function is called several thousand times. |
|
for i is quite faster lol |
Contributor
|
for loop is faster only if you initially know the length of the table, and nothing will iterate through the table ~100 million times |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR aims to add a color cache and replace all
ipairsstatements with afor i = 1loop.I haven't tested it with other glide-compatible addons, but this one should work.
Sorry for StyledStrike.
