Shotness analyzer quality#14
Merged
Merged
Conversation
…nstants - Add Strength field to NodeCouplingData with formula: co_changes / max(co_changes, changes_a, changes_b) - Add AvgCouplingStrength to AggregateData - Fix classifyChangeRisk to return LOW instead of empty string - Export RiskLevelHigh, RiskLevelMedium, RiskLevelLow constants - Fix TotalCouplings to count upper triangle only - Add tests for coupling strength, risk classification, aggregator, merge state, extractTC, genLine2Node, resolveEndLine, and more Co-authored-by: Dmytro Gajewski <dmytrogajewski@users.noreply.github.com>
- Add Serialize/SerializeTICKs overrides for FormatText and FormatPlot - Implement generateText with Summary, Hottest Functions, Risk Assessment, and Strongest Couplings sections using terminal utilities - Add generatePlot method for standalone plot rendering - Add comprehensive tests for text output and plot generation - Follow burndown/devs pattern for terminal formatting Co-authored-by: Dmytro Gajewski <dmytrogajewski@users.noreply.github.com>
- Add coupling strength formula and interpretation guide - Add risk classification table with thresholds - Add text format example output - Add metrics reference tables for all output fields - Add actionable insights section for interpreting results - Update README with methodology context and new metrics Co-authored-by: Dmytro Gajewski <dmytrogajewski@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the
shotnessanalyzer's correctness and UX by implementing industry-standard coupling strength normalization, consistent risk classification, and a human-readable text output format.The analyzer's previous implementation lacked normalized coupling strength, had inconsistent risk classification, and did not provide a user-friendly text output, which are critical for an internal assessment tool where accuracy and clarity are paramount.