Skip to content

Refresh the Chrome bundle and adapt current sidebar/DNR APIs - #28

Open
RVZO6 wants to merge 2 commits into
SunkenInTime:mainfrom
RVZO6:fix/chrome-bundle-refresh
Open

RVZO6 wants to merge 2 commits into
SunkenInTime:mainfrom
RVZO6:fix/chrome-bundle-refresh

Conversation

@RVZO6

@RVZO6 RVZO6 commented Oct 9, 2026 •

Copy link
Copy Markdown

Scope

Refresh the imported Chrome application to extension 1.26.901.11451, build 834ab2c3159a7637c75db757ad053344da009e8b, retaining the Firefox adapter and native companion version 1.4.12. The large generated-asset diff is the vendor refresh; locator, AX, font, host-sizing, file-path, packaging, and fork-only CI changes are excluded.

Required Firefox adaptations

The current bundle queries sidePanel options and persists the local destination before boot. Its controlled-tab header reconciler also requires Firefox's native DNR permission, Chromium enum constants that Firefox does not provide, and conversion of the Gecko extension ID into the actual moz-extension initiator hostname. Without these adaptations, the current reconciler fails when a tab is claimed.

Preserve the existing Firefox tab-mention provider, copy the companion logo to a stable non-hashed path, and verify packaged relative module dependencies. The intentional minified tab-mention adaptation is reproducible and idempotent through scripts/apply-upstream-patches.mjs; other imported application assets retain upstream bytes.

Validation and limits

  • pnpm test and the existing isolated Zen lifecycle test pass on this branch, including actual native DNR session-rule installation, hostname translation, and removal.
  • A private full-extension Zen smoke test passes background startup, upstream context-menu registration, actual controlled-tab header reconciliation, and the sidebar's disconnected recovery rendering. Native messaging is blocked in that disposable profile.
  • Only existing tests are updated; no new test files or suites are added.

Authenticated ChatGPT conversation startup has not been certified by this smoke test. The Chrome-only Work sidebar host remains unsupported; Firefox retains the local Codex sidebar. The native companion and the maintainer's release workflow are unchanged. Typography and host sizing are separate PRs, and this branch intentionally does not include those fixes.


Generated by GPT 6.1 Sol in Codex, using T3 Code.

RetriggerConfidence Score: 5/5

No blocking issue was found in the reviewed changes; authenticated conversation startup and native-browser behavior remain outside the independently verified coverage.

T-Rex evidence

Native browser test blocked before launch

  • Attempted the existing live test and captured its missing-FIREFOX_BINARY error, showing native Firefox behavior remains unverified.

Executed validation command source

  • This executed runner captures each command, working directory, exit code, and observed output, providing traceable test evidence.

Checkout, changed source, and exact call-site quote

  • Captured the requested checkout, clean tracked diff, browser availability checks, changed adapter source, and exact background quote, confirming source provenance and the native blocker.

Evidence from the check

  • This executed harness loads the full adapter and actual upstream reconciler against a stateful mock, making the before/after contract checks reproducible.

Evidence from the check

  • This executed runner captures each command, working directory, exit code, and observed output, providing traceable test evidence.

Command output from the check

  • Ran the existing Firefox compatibility test at the requested head and captured exit code 0, showing the existing mock assertions pass.

Command output from the check

  • Executed the refreshed reconciler with the old adapter and observed enum and untranslated-domain failures, establishing the mock-contract baseline.

Command output from the check

  • Executed the same reconciler with the head adapter and verified installation, translation, replacement, removal, and retry, showing the scoped mock contract passes.

Command output from the check

  • Attempted the existing live test and captured its missing-FIREFOX_BINARY error, showing native Firefox behavior remains unverified.

Command output from the check

  • Captured the requested checkout, clean tracked diff, browser availability checks, changed adapter source, and exact background quote, confirming source provenance and the native blocker.

Evidence from the check

  • This executed Node harness loads either real adapter revision and exercises bootstrap, extracted upstream consumers, destination persistence, and companion recovery fixtures, making the comparison reproducible.

Evidence from the check

  • This executed Python runner invokes both adapter comparisons and the three existing focused tests while recording commands, working directories, and exit codes, making the captured evidence reproducible.

Command output from the check

  • The harness exercised the pre-change adapter against refreshed upstream consumers and captured missing option APIs plus absent or stale destination state, establishing the comparison baseline.

Command output from the check

  • The harness and existing tests exercised PR head and captured coherent local options, destination repair and restoration, recovery callbacks, and an unchanged tracked worktree, showing no regression in the tested contract.

View artifacts

Summary

Refreshes the imported application to extension version 1.26.901.11451 while keeping the Firefox companion at 1.4.12.

  • The Firefox extension carries the refreshed Chrome app bundle.
  • The refreshed app keeps Firefox’s local Codex sidebar in sync.
  • Firefox can install the refreshed app’s tab header rules.
  • Firefox tab mentions stay available in the refreshed sidebar.

No actionable defect or blocking issue was established in the reviewed changes.

RVZO6 explicitly identifies the Chrome Work sidebar host as unsupported; Firefox retains the local Codex sidebar. RVZO6 defers typography and host-sizing fixes to separate PRs and excludes them from this branch. These acknowledged limits are not reported as defects. RVZO6 also states that authenticated ChatGPT conversation startup has not been certified and that native messaging was blocked in the disposable smoke-test profile; the focused checks do not certify authenticated startup or native companion connectivity.

T-Rex validation blocked

Independent native Firefox checks could not launch because FIREFOX_BINARY was unset and Firefox/Zen and web-ext were unavailable on PATH. The passing API-fixture checks do not establish native browser rendering or actual request-header enforcement.

Reviews (1) · Last reviewed commit: "Record the imported Chrome bundle build ..." · Reviewed by Greptile

@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Walkthrough

Warning

Review details and warnings were omitted to fit the comment limit.

@RVZO6

RVZO6 commented Oct 9, 2026

Copy link
Copy Markdown
Author

Validation follow-up: no actionable review findings were present. Full npm test and the existing npm run test:live both pass at 2ab21aa on Linux ARM64 with disposable headless Firefox 157.0.1, including native DNR rule installation, Gecko initiator hostname translation, and removal. No code changes were needed. This doesn't certify authenticated ChatGPT conversation startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant