Repository navigation
Show a one-time welcome tour on the first desktop launch - #296
Merged
Merged
Conversation
The first desktop release with accounts opens straight into the library with nothing to say what changed. A three-step card now says the local library is untouched, offers sign-in, and points at Replays. It shows once per install, waits for any update dialog and for launches that open a file or link, skips the library step on an empty install, and What's new leads back to it. The seen flag is a new AppPreferences field whose default (not seen) reproduces the old behavior, so stores written before it read correctly without a migration; a test reads such a record. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The library's WebView warning could open after the tour and stack on it, so the tour now starts once that warning, if any, has been dealt with. Two tour tests re-pumped an identical tree, so the stand-in library never mounted again and the checks could not fail; each pump now starts from an empty tree. The restart test now reopens the box so the flag is read back from disk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Opening the tour from What's new now marks it seen, and the launch path checks again after its update wait, so a tour the user already viewed doesn't come back later that launch or on the next. Step 1 tiles use the library's own badge wording, "On this device". The drawn Capture button is a neutral raised surface: it can't be pressed, and violet is kept for things that can. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first desktop release with accounts opens straight into the library and says nothing about what changed. Someone updating from 4.6 sees a new Log In button and has to guess whether their strategies moved. This adds the welcome card Dara picked (mock 3, "Paged, with actions"): three steps, one at a time, each one something the user can act on.
Mock on the left, the release build on the right, one row per step:
Step 2, mock vs. build (unchanged since the first round):
The walkthrough GIF and the step 2 picture are from the first round. Since then, the step 1 tiles say "On this device" and the drawn Capture button is neutral.
What it does
Back on steps 2 and 3. The dots show the step and jump on click, and only the current one is violet. The X closes it. Every step is laid out at once (an IndexedStack), so the card keeps the tallest step's height and the buttons never move. The pictures are small widgets built from the real map thumbnails, agent icons and Lucide icons, with the library's own dot grid behind them (
welcome_tour_pictures.dart). All the copy is inWelcomeTourCopyat the top ofwelcome_tour_dialog.dart. The replay step's two strings sit in one marked block there, since what the release says about replays may still change (Icarus reads replays up to VALORANT 13.06 for now). The label says "New in this update", with no version number.When it shows
showWelcomeTourAtLaunchruns once per app run, after the library's first frame. It shows nothing on the web beta (PlatformPolicy.isWebBeta), nothing once the install has seen it, and nothing on a launch that was asked to open a file or a link (mainsetslaunchOpensFileOrLinkProviderfrom the launch arguments and the initial deep link, which covers .ica, .vrf, sign-in callbacks and share links). It waits for the update check (Store check, then the direct-install updater's first check, up to 10 s). If an update is waiting, or the check hasn't answered in time, it waits for the next launch instead of stacking on the update dialog. It also waits until the library's WebView warning, if there is one, has been closed. Then it checks the library is the top route, so it never opens over another dialog or the editor. A launch it skips leaves the flag unset, so the next plain launch shows it. Opening the tour from What's new also marks it seen. The launch path checks the flag again after its wait, so a tour the user has already viewed doesn't come back.An install with no local strategies or folders skips step 1, because its claim is about existing work, so it gets two steps.
"Seen" is a new
AppPreferences.welcomeTourSeenfield (Hive index 20, default false), set as soon as the card is on screen. Stores written before this field read as false, so updating users see the card once.test/welcome_tour_test.dartwrites a record without field 20 and reads it back. No library data changes.WindowsDesktopUpdateControllergainsfirstCheck, the future of the check it already starts in its constructor, so the tour can tell "no update" from "not known yet".A way back
What's new gets one quiet link under its title, "Show the welcome tour" (muted, brighter on hover). It closes What's new and opens the tour in its place. It's hidden on the web beta.
Ground truth
Windows release build (
--dart-define=ICARUS_CLOUD_ENVIRONMENT=development), each run on its own--hive-store-dir, driven from inside the app by a scratch driver that isn't in this PR:A site execute.ica), reset the flag, and relaunched. The card was up within about 1.5 s of launch on step 1. Next, then Sign in opened the AuthDialog over the card; closing it returned to step 2. Not now, Back, Not now, then Open Replays landed on the Replays tab (log:tab=replays). The flag readseen=true. On relaunch there was no card. What's new, then "Show the welcome tour", opened it again on step 1.Every Icarus build on this PC shares one session file, and someone else's session was in it. To see the signed-out runs without signing anyone out, my scratch build gave Supabase an empty session store when an env var was set. That patch isn't in this PR.
Calls Dara might undo
Settings.raisedSurfaceforSettings.raisedPrimaryin_CaptureButton.Review
Round 0: an Opus subagent read the diff statically. It found no blockers. It did find that two widget tests couldn't fail: they re-pumped an identical tree, so the stand-in library never mounted again. The restart test also read the flag back from Hive's cache, not from disk. All three are fixed. From the same review, the WebView warning could open after the tour, and the library now waits for it first.
Astra, round 1: no functional blockers. It confirmed Hive field 20 has no collision and that 4.6.3's reader ignores the unknown index. If someone rolls back and then upgrades again, the tour shows once more, which is acceptable. It found two things, both fixed in the third commit:
WelcomeTourDialog.show, and the launch path rechecks the flag after its wait. A new test opens the tour from What's new while the launch is still waiting on the update check, and checks the tour doesn't show again when the check answers.A new test also covers an update check that never answers: after 10 s the tour waits for the next launch, and stays put when the check finally answers. For each guard (seen, opened file, once per run, the recheck after the wait, marking in
show), I removed it and watched a test fail.I left the spacing (18/20/6 px) and the 11 px picture text as they are, because they come from the mock.
Not covered
cloud_startup_testandweb_beta_library_testpump the real library on desktop, where the card now appears over it. They now mark the tour as already decided, so they keep testing what they were written for.ci: analyze test web desktop
🤖 Generated with Claude Code