Repository navigation
Name each ability for the icon it draws - #317
Merged
Merged
Conversation
Phoenix, Deadlock, Vyse and Miks each had two ability names swapped against their icons and shapes: hovering Phoenix's flash said Hot Hands, Deadlock's net said Barrier Mesh, Miks's smoke said Harmonize, Vyse's wall said Razorvine. The names followed the game's key order, but these four agents' icons don't. Names are display only; saved abilities keep their type and index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hovering an ability in the editor's ability bar showed the wrong name for four agents. Phoenix's flash read "Hot Hands" and her fireball "Curveball". Deadlock's net read "Barrier Mesh". Miks's smoke read "Harmonize". Vyse's wall read "Razorvine". The new replay killfeed rows in #314 show the same names next to the right icons.
The names in
lib/const/agents.dartfollowed the game's C Q E X key order, but these four agents' icons and shapes at each index don't follow it. Icarus index 0 for Deadlock draws GravNet, and index 2 for Miks draws Waveform's smoke (valorant-api.com confirms which of Miks's abilities is the smoke). The label should name what the slot draws, so this swaps the names and leaves the icons alone.agents.dart: swapped names for Phoenix (1/2), Deadlock (0/2), Vyse (0/1) and Miks (2/3).test/agent_ability_names_test.dart: now pins names to what each index draws, with a note on why four agents aren't in key order.replay_ability_catalog.dart: the four comments that said "agents.dart names them the other way" no longer apply.Names are display only. Hive and .ica keep each ability's type and index, so nothing saved changes.
Ground truth: release build, the editor's ability bar, hovering each swapped ability on this branch and on main (grid above). Ability tests and the replay catalog tests pass.
ci: test
🤖 Generated with Claude Code