fix: resolve active Chromium profile for browser history import#402
Open
vingeraycn wants to merge 1 commit into
Open
fix: resolve active Chromium profile for browser history import#402vingeraycn wants to merge 1 commit into
vingeraycn wants to merge 1 commit into
Conversation
Previously, all Chromium-family browsers (Chrome, Arc, Brave, Edge, Vivaldi) hardcoded 'Default/History' as the history file path. Users with non-default Chrome profiles (e.g. 'Profile 7') could not import their browser history. This adds resolveChromiumHistoryPath() which: 1. Reads 'Local State' to detect the last-used profile 2. Falls back to 'Default' if Local State is missing or profile has no History 3. Scans all profile subdirectories as a final fallback The ImportableBrowser interface and importFromBrowser() signature are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All Chromium-family browsers hardcode
Default/Historyas the history file path inlistImportableBrowsers(). Users with non-default Chrome profiles (e.g. 'Profile 7') cannot import their browser history — the browser shows as unavailable in the import dropdown.Fixes #401
Solution
Added
resolveChromiumHistoryPath(rootDir)which dynamically resolves the correct profile directory:{rootDir}/Local StateJSON to findprofile.last_used(the active profile)Default/HistoryProfile *andDefaultsubdirectories, returning the first with a History fileDefault/Historypath even if it doesn't exist (caller checks existence)Changes
resolveChromiumHistoryPath()helper with the 4-tier resolution algorithmdbPathtorootDirImportableBrowserinterface — fully backward compatibleimportFromBrowser()signature — existing callers unaffectedTesting