Add support for Windows Mixed Reality controllers#130
Add support for Windows Mixed Reality controllers#130CheesecakeCG wants to merge 15 commits intoSupreeeme:mainfrom
Conversation
|
Feel free to split odyssey and reverb g2 support into separate PRs, if you'd like. |
CheesecakeCG
force-pushed
the
wmr-controller-support
branch
from
4126f7f to
60bdb2d
Compare
CheesecakeCG
force-pushed
the
wmr-controller-support
branch
from
2f0d8c6 to
32f1b19
Compare
Supreeeme
left a comment
Supreeeme
left a comment
There was a problem hiding this comment.
These could use some simple verify_bindings tests. You can look at the ones in the other profiles for inspiration.
| (ControllerType::HPMotionController, &ReverbG2Controller), | ||
| ( | ||
| ControllerType::SamsungOdysseyController, | ||
| &SamsungOdysseyController, | ||
| ), |
There was a problem hiding this comment.
Since these controller types are locked behind extensions, we will need to handle the extensions not being available in some way.
There was a problem hiding this comment.
#298 adds a mechanism for this, so you can use that once that gets merged.
CheesecakeCG
force-pushed
the
wmr-controller-support
branch
from
54a872e to
5209b7d
Compare
|
I am not sure if this is a good place for this or not but I built Cheesecakes wmr-controller-support branch and tested it with Xplane11 and ended up with a crash. I was in communication with Supreme in Discord and they were thinking it was likely that Cheesecakes branch just needs to be rebased. I would love to test and am hopeful that Cheesecake will see this and be able to do that. For reference this is the log from the crash https://bin.garudalinux.org/?d2bb0dfa11ef9f74#7uRhUQbjF928BVyHuLm8km9aXs7Cp8WRc6LBzE2YspYC |
CheesecakeCG
force-pushed
the
wmr-controller-support
branch
from
5209b7d to
d092b98
Compare
|
Unfortunately the rebase didn't help and resulted in the same error. https://bin.garudalinux.org/?11a46fbeba5363eb#BAPbEdpGxLu6gvtc8L7AZ5KZQaoYLyPU7XiYnNJQuG6 I will try to compile the default xrizer and make sure it works, as I have only ever used OpenComposite with Xplane11. |
|
@toyowheelin Which kind of controllers are you using? Reverb G2? |
|
I have a Samsung Odyssey + setup. |
|
Let me know if you need any more info to look into this, I would love to help make this work. |
I still need the render_model_name for the Samsung controllers, unless SteamVR doesn't actually show different models for those controllers. I'm not entirely sure where in the SteamVR driver that's defined though, I'm able to see it in the other drivers but not for WMR. |
|
It'd be nice to have these in, if you want to move Samsung support to a separate PR. |
Co-authored-by: Supreeeme <yungwallace@live.com>
CheesecakeCG
force-pushed
the
wmr-controller-support
branch
from
d092b98 to
5c4b3e8
Compare
| left: c"C:\\Users\\steamuser\\AppData\\Local\\Microsoft/Windows/OpenVR\\controller_1642_1118_1\\controller.obj", | ||
| right: c"C:\\Users\\steamuser\\AppData\\Local\\Microsoft/Windows/OpenVR\\controller_1642_1118_2\\controller.obj" |
There was a problem hiding this comment.
I assume this is what's returned in Windows? Kind of cursed...
There was a problem hiding this comment.
It's pretty close to what's returned on Windows, except the user name usually matches the actual user's username. I figured most of the time, people will be running games with XRizer through Proton and that's the username used there.
3 participants
I've only added support for the original WMR controllers so far, and I haven't much tested outside of VRChat and ChilloutVR.
Also, the grip poses in Monado might be flipped... and the ones I'm using here are rotated wrong.The offsets are now fixed in Beyley's
rift-driver-trackingbranch and Thaytan'sdev-constellation-controller-trackingbranch of Monado.I'll need other people to test the last two controllers.