Conversation
#36 landed after the fingerprints were recorded, so both tracked sets reported stale. Everything it changed in the scripts those calibrations run is comment or docstring text, apart from a behaviour-preserving simplification of `get_effective_config`, so the artefacts are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#36 merged after the fingerprints in #37 were recorded, so on current
mainboth tracked artefact sets report
[STALE]on all five steps:I checked every file #36 touched that appears in a calibration DAG. All of them
are comment or docstring edits, except one behaviour-preserving simplification
in
get_effective_config(an unreachablepassbranch folded into thecondition). The artefacts cannot have moved, so this re-stamps rather than
recalibrates --
tools/calibrate --recordfor both sets, no solving.Both sets are green afterwards.
This is the expected cost of hashing code: an inert edit to any script in a
step's DAG marks it stale, and
--recordis the acknowledgement. Worth knowingwhen a docs-only PR touches Python files.