Draft
Conversation
Co-authored-by: jak574 <15330708+jak574@users.noreply.github.com>
Co-authored-by: jak574 <15330708+jak574@users.noreply.github.com>
Co-authored-by: jak574 <15330708+jak574@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ObsLocTAP capability to Swift VO
Add ObsLocTAP endpoint with cone search support
Nov 7, 2025
jak574
requested changes
Nov 7, 2025
Contributor
There was a problem hiding this comment.
@copilot The code uses just the PlanQuery to get planned observations. It should also use ObsQuery to get observations that have been executed. Note: Observations should not double up, so only targets after the most recent ObsQuery entry should be included in planned. Also implement the execution_status entry in the table.
jak574
self-requested a review
November 7, 2025 14:14
jak574
requested changes
Nov 7, 2025
jak574
left a comment
Contributor
There was a problem hiding this comment.
@github-copilot @copilot The code uses just the PlanQuery to get planned observations. It should also use ObsQuery to get observations that have been executed. Note: Observations should not double up, so only targets after the most recent ObsQuery entry should be included in planned. Also implement the execution_status entry in the table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Closes #[issue_number]
Implements ObsLocTAP (Observatory Locator Table Access Protocol) IVOA standard endpoint with cone search capability using
swifttools.swift_too.PlanQueryto query Swift Pre-Planned Science Timeline.Solution Description
Core Implementation
swift_vo/obsloctap/: New module implementing ObsLocTAP serviceschema.py: Parameter models for position (RA, DEC, RADIUS) and time rangeservice.py: Query logic usingPlanQuery, VOTable formatting per ObsLocTAP specapi.py: FastAPI endpoint/obsloctap/querywith parameter parsingVOSI Compliance
/obsloctap/availabilityand/obsloctap/capabilitiesendpointsswift_vo/vosi/api.pywith ObsLocTAP service metadataIntegration
app.pytests/swift_vo/test_obsloctap.pyExample Usage
Returns VOTable with fields:
obs_id,s_ra,s_dec,t_planning,t_start,t_stop,target_nameCode Quality
Project-Specific Pull Request Checklists
New Feature Checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.swift.psu.edu/home/REDACTED/work/swift-vo/swift-vo/.venv/bin/python3 .venv/bin/pytest tests/ -v(dns block)/home/REDACTED/work/swift-vo/swift-vo/.venv/bin/python3 .venv/bin/pytest tests/swift_vo/test_obsloctap.py -v(dns block)/home/REDACTED/work/swift-vo/swift-vo/.venv/bin/python3 .venv/bin/pytest tests/ -v --tb=short(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.