fix: Add in missing endpoint parameters#34
Open
jak574 wants to merge 33 commits into
Open
Conversation
Push to version 3.0.19
Update to swifttools 3.0.21
Add deploy GitHub workflow
Merge GitLab master branch into main
Co-authored-by: Phil Evans <pae9@leicester.ac.uk>
…nt fixes to swift_too. (Swift-SOT#9) Apply black style formatting with 120 char line lengths. Update ruff.toml to minimize linting issues. Fix bad noqa Fix name of action
* Fixed various minor python issues giving linting errors. * Re-applied formatting fixes * Reformatted prod_requst using ruff instead of black * Modified ruff.toml to include F/E otherwise vscode is not using it properly, I think * Reverted last change to ruff.toml; was a mistake * Fixed type checks to use isinstance() * Completed reversion of ruff.toml - my error * FFS, think I've finally got the formatting as ruff wants it * Remove one ruff filter --------- Co-authored-by: Jamie Kennea <jak574@gmail.com>
…g, to reflect the creation of the ukssdc package. (Swift-SOT#13) ALso removed scripts and files which are specific to the rendering of these Markdown documents on the swift.ac.uk website.
- Merging to main
* updated link for users to create a new GitHub issue from Swift-SOT#14 * updated documentation notebooks zip link from Swift-SOT#14 * fixed GitHub markdown by updating citation title links from Swift-SOT#14 - NEEDS REVIEW
…API versions ready for a new release (Swift-SOT#20)
…AT GRB catalogue has been updated
* Auto-fixes * More fixes * Fix formatting of notebooks * Fix formatting of UKSSDC notebooks * Update pre-commit * Fix as per Phil * Commit as per Phil * Mask correct use of == False/True as noqa: E712 * Modified the documentation for ukssdc.query.GRB to remove the == False and instead use .astype(bool) --------- Co-authored-by: Phil Evans <pae9@leicester.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends the query and response schemas for several Swift TOO (Target of Opportunity) API endpoints, adding support for pagination, sorting, and additional filtering parameters. These changes make the API more flexible and allow clients to retrieve data with finer control over results.
The most important changes are:
Pagination and Sorting Enhancements:
limit,offset,sort_by, andorderfields to the get and response schemas for calendar, guano, AFST, PPST, and requests endpoints to support pagination and sorting in API queries and responses. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Additional Filtering and Metadata:
queue_num(guano),gw_event(AFST), andusername(guano, requests) to allow more specific filtering and metadata tracking in queries and results. [1] [2] [3] [4]Code Cleanup:
printstatement from thevalidate_parametersmethod inguano.pyfor cleaner logs.API URL Change for Local Development:
API_URLinconstants.pyto point tolocalhost:8000instead of the production server, making local development and testing easier by default.