fix(lint): resolve the 4 ESLint errors blocking CI on main - #542
Merged
Conversation
CI has been red on main for every recent push because `pnpm run lint` exits 1 on 4 errors (the 254 warnings are non-blocking). Nothing after the Lint step has been running as a result. - components/mobile/MobileFooter.tsx: the file was committed with every quote character stripped, so the leading backtick opened a template literal that never closed and the whole file failed to parse. Restored the string quoting; no behaviour change intended. - app/page.tsx: <KineticExplorer /> was rendered without being imported (react/jsx-no-undef). Added the missing import. - hooks/useDriverReputation.ts: the effect called setState synchronously (react-hooks/set-state-in-effect). The settled result now carries the driverId it belongs to, so loading is derived rather than written back into state from the effect. - hooks/useTheme.ts: updateTheme was read by an effect declared above it (react-hooks/immutability). Hoisted it into a useCallback keyed on userId and added it to the effect deps. Lint now reports 0 errors. Type-check still fails on 280 pre-existing errors across 44 files, which is out of scope here.
AdaBebe0
force-pushed
the
fix/lint-errors-ci
branch
from
September 1, 2026 03:47
e90c56d to
3e9c8c0
Compare
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI has been failing on
mainfor every recent push — including a commit that only editedREADME.md. The failure is at the Lint step:pnpm run lintexits 1 on 4 errors (the 254 warnings don't block). Because Lint runs first, Type Check, Test, and Build Verification have not run at all on any recent PR.This means every open PR shows a red CI that has nothing to do with its own changes.
Fixes
components/mobile/MobileFooter.tsxapp/page.tsxreact/jsx-no-undef<KineticExplorer />was rendered without being imported. Added the missing import.hooks/useDriverReputation.tsreact-hooks/set-state-in-effectsetStatesynchronously. The settled result now carries thedriverIdit belongs to, so loading is derived rather than written back into state from the effect.hooks/useTheme.tsreact-hooks/immutabilityupdateThemewas read by an effect declared above it. Hoisted into auseCallbackkeyed onuserIdand added to the effect deps.MobileFooter.tsxis a pure restoration of the intended quoting — no behaviour change.Verification
pnpm run lint→ 0 errors, 254 warnings (was 4 errors)DriverReputation.test.tsxandKineticExplorer.test.tsxpassKnown follow-up — this does not make CI fully green
With Lint unblocked, CI now advances to Type Check, which fails on roughly 300 pre-existing
tsc --noEmiterrors across 44 files (mostly test files, plus several hooks). Those are unrelated to this change and are deliberately out of scope here — this PR's job is to unblock the pipeline and make the real blocker visible. Happy to take the type errors on in a follow-up if that's wanted.