Skip to content

library splits - #56

Merged
Swiftshine merged 8 commits into
Swiftshine:mainfrom
ThePlayerRolo:library-splits
Jul 24, 2026
Merged

library splits#56
Swiftshine merged 8 commits into
Swiftshine:mainfrom
ThePlayerRolo:library-splits

Conversation

@ThePlayerRolo

@ThePlayerRolo ThePlayerRolo commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

some more library splits
I do want to finish revolution and nw4r sdk splits but idk if that'd be ok with you since that would mean adding them to the configuration which would add progress. idk if we still are at the point where there is too little game code to not allow sdk code or not. would it be ok if it was added due to new splits or?

@decomp-dev

decomp-dev Bot commented Jul 10, 2026

Copy link
Copy Markdown

Report for S72E01 (6ad3bfa - 0d42705)

Total code: 4171604 bytes (-60 bytes)
Total functions: 27542 (-5)
📉 Matched data: 7.34% (-0.01%, -96 bytes)

✅ 1 new match
Unit Item Bytes Before After
main/revolution/OS/OSTime .data +96 0.00% 100.00%
🥀 1 broken match
Unit Item Bytes Before After
main/revolution/OS/OSStateTM .bss -192 100.00% 0.00%

@ThePlayerRolo

Copy link
Copy Markdown
Contributor Author

UPDATE: I split all of OS and added it to the configure.py BUT didn't make any matching edits besides renaming an incorrect symbol. If you want me to comment out the new OS stuff in configure.py for now I can also do thatr

@ThePlayerRolo

Copy link
Copy Markdown
Contributor Author

added more splits

@ThePlayerRolo

ThePlayerRolo commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

added gx splits + reworked revolution libs to match the map more

@Swiftshine

Copy link
Copy Markdown
Owner

would it be ok if it was added due to new splits or?

again i want to put a hold on matching/linking any RVL/NW4R unless it's necessary to match/link actual game code. SDK is something to be done after

@ThePlayerRolo

Copy link
Copy Markdown
Contributor Author

would it be ok if it was added due to new splits or?

again i want to put a hold on matching/linking any RVL/NW4R unless it's necessary to match/link actual game code. SDK is something to be done after

ok, I'll keep the splits but comment out the configure.py

@ThePlayerRolo

ThePlayerRolo commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

ok so now the splits exist but now they shouldn't affect %

@ThePlayerRolo

ThePlayerRolo commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

UPDATE: the only thing that has more matches is OSStateTM due to the new splits. if you want me to comment it out to prevent it I can since this pr is meant for splits and not matching sdk

@ThePlayerRolo

Copy link
Copy Markdown
Contributor Author

decided to comment out OSStateTm to prevent too much extra matches

@ThePlayerRolo

ThePlayerRolo commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Should be ready for review but if you want it I can remove the new nw4r/rvl_sdk splits completely (currently they don't really effect progress)

By the way does libMobiclip count as a RVL_SDK library to avoid since no one has really decompiled it? (I've only seen one old unfinished decomp)

@Swiftshine

Swiftshine commented Jul 24, 2026

Copy link
Copy Markdown
Owner
  1. you can keep the splits since i wouldn't want to make you undo all your current work just to re-do it in the future

  2. nope. feel free to work on that if you want

@Swiftshine
Swiftshine merged commit 2be1c20 into Swiftshine:main Jul 24, 2026
1 check passed
@ThePlayerRolo
ThePlayerRolo deleted the library-splits branch July 24, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants