[#5] 비밀번호 기능 중복 병합으로 깨진 빌드 복구 - #22
Merged
Merged
Conversation
feat/5-login(PR #20) 재병합 과정에서, 팀의 비밀번호 기능(PasswordController/ PasswordService/EmailSender 재설계)과 별도로 구현됐던 회원 셀프서비스(#1)· 비밀번호 재설정(#15)이 충돌·중복된 채 병합되어 빌드가 깨졌다. 특히 EmailVerificationService에 issueCode가 중복 정의되어 Lombok 처리가 중단되고, @Getter/@builder 등 생성 메서드 전반이 사라지는 연쇄 컴파일 오류가 났다. 권위 있는 팀 구현(feat/5-login)을 채택하고 중복분을 제거한다. - EmailVerificationService: 중복 issueCode와 sendResetCode(이미 제거된 sendVerificationCode 호출) 정리 - PasswordResetController/Docs, ChangePasswordRequest/ResetPasswordRequest 삭제 (팀의 PasswordController + PasswordChangeRequest/PasswordResetRequest로 일원화) - MemberController/MemberService의 changePassword·resetPassword 제거(매핑 충돌 해소) - 프로필 수정(PATCH /api/me)은 팀 구현에 없으므로 유지 - 중복 테스트(PasswordResetApiTest) 삭제, MemberSelfServiceApiTest는 프로필 테스트만 유지 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 작업 내용
✅ PR 유형
🧪 테스트 내용
🙋🏻 참고 사항
🔗 관련 이슈
resolved: #5