chore: remove some unused components#4040
Merged
Merged
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-4040.dev.renku.ch |
leafty
approved these changes
Feb 23, 2026
| export const ButtonWithMenuV2 = SplitButtonWithMenu; | ||
|
|
||
| export function SplitButtonWithMenu({ | ||
| export function ButtonWithMenuV2({ |
Member
There was a problem hiding this comment.
Component names are a bit confusing: which component should we use?
Member
Author
There was a problem hiding this comment.
SplitButtonWithMenu was not imported anywhere, only ButtonWithMenuV2 was.
I agree that the name is not the best. I'm all in favor of changing it, perhaps together with fixing the button (see #3464 -- you stared #3465 but I can also give it a look since I need that somewhere else too and I can make it generic)
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR touches error handling too
/deploy renku=leafty/ui-ssr-update extra-values=ui.client.resources.limits.memory=300Mi,ui.client.resources.requests.memory=300Mi