Skip to content

build: prevent Docker errors while building#4206

Merged
lorenzo-cavazzi merged 4 commits into
mainfrom
lorenzo/prevent-docker-errors
Jun 4, 2026
Merged

build: prevent Docker errors while building#4206
lorenzo-cavazzi merged 4 commits into
mainfrom
lorenzo/prevent-docker-errors

Conversation

@lorenzo-cavazzi
Copy link
Copy Markdown
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Jun 4, 2026

We get a bunch of errors when building due to linting

[...]
#22 24.12 Error: Could not find config file.
#22 24.12     at assertConfigurationExists (/app/node_modules/eslint/lib/config/config-loader.js:80:17)
#22 24.12     at LegacyConfigLoader.loadConfigArrayForFile (/app/node_modules/eslint/lib/config/config-loader.js:414:3)
#22 24.12     at async ESLint.calculateConfigForFile (/app/node_modules/eslint/lib/eslint/eslint.js:1299:4)
#22 24.12     at async ESLint.isPathIgnored (/app/node_modules/eslint/lib/eslint/eslint.js:1339:18) {
#22 24.12   messageTemplate: 'config-file-missing'
#22 24.12 }
#22 24.12 Error: Could not find config file.
#22 24.12     at assertConfigurationExists (/app/node_modules/eslint/lib/config/config-loader.js:80:17)
#22 24.12     at LegacyConfigLoader.loadConfigArrayForFile (/app/node_modules/eslint/lib/config/config-loader.js:414:3)
#22 24.12     at async ESLint.calculateConfigForFile (/app/node_modules/eslint/lib/eslint/eslint.js:1299:4)
#22 24.12     at async ESLint.isPathIgnored (/app/node_modules/eslint/lib/eslint/eslint.js:1339:18) {
#22 24.12   messageTemplate: 'config-file-missing'
#22 24.12 }
[...]

/deploy renku=release-2.18.0

@RenkuBot
Copy link
Copy Markdown
Contributor

RenkuBot commented Jun 4, 2026

You can access the deployment of this PR at https://renku-ci-ui-4206.dev.renku.ch

@lorenzo-cavazzi lorenzo-cavazzi changed the title build: prevent Dcoker errors when building build: prevent Docker errors while building Jun 4, 2026
@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as ready for review June 4, 2026 11:39
@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner June 4, 2026 11:39
Comment thread client/Dockerfile Outdated
RUN npm ci

COPY react-router.config.ts tsconfig.json tsconfig.node.json vite.config.ts /app/
COPY react-router.config.ts tsconfig.json tsconfig.node.json vite.config.ts eslint.config.mjs /app/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we add the eslint config if it's not used in production builds?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, I forgot to revert the first commit that was simply copying the config file for the linter

Copy link
Copy Markdown
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: we perform the lint action in CI/CD on all commits, so this is reasonable.

@lorenzo-cavazzi lorenzo-cavazzi merged commit 6442f32 into main Jun 4, 2026
32 of 36 checks passed
@lorenzo-cavazzi lorenzo-cavazzi deleted the lorenzo/prevent-docker-errors branch June 4, 2026 12:11
@RenkuBot
Copy link
Copy Markdown
Contributor

RenkuBot commented Jun 4, 2026

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants