Skip to content

Fix crash when MCP plugins are persisted with Guid.Empty as Id #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CowboyHat-exe wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Fix crash when MCP plugins are persisted with Guid.Empty as Id #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Everywhere.Core/Configuration/Settings/PluginSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Text.Json.Serialization;
using System.Text.Json.Serialization;
using CommunityToolkit.Mvvm.ComponentModel;
using Everywhere.Chat.Plugins;
using Everywhere.Collections;
Expand Down Expand Up @@ -76,6 +76,11 @@ public McpChatPluginEntity(McpChatPlugin mcpChatPlugin)
return null;
}

// Self-heal persisted Guid.Empty IDs; they cause KernelPluginCollection to throw
// a duplicate-key ArgumentException when two or more zero-ID plugins are loaded.
if (Id == Guid.Empty)
Id = Guid.CreateVersion7();

return new McpChatPlugin(Id, transportConfiguration);
}
}
Loading